Add metricsource commands and custom alert targets (metric alerts phase 2) - #67
Merged
Conversation
deploys metricsource set/get/list/delete/series/query for Prometheus scrape sources (SPEC-metric-alerts.md Phase 2). Set is a full upsert. alert create/update grow -kind/-source/-series and accept value|rate metrics for kind=custom. Update-merge seeds Kind/Source/Series from get. Pin api to 039b9e7c254328051faddb210ad58980b5ceb890.
Point at the squash-merge on main (5b928d9) instead of the unmerged feat/custom-metrics commit (1e9d694).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploys metricsource set/get/list/delete/series/queryfor Prometheus scrape sources (SPEC-metric-alerts.md Phase 2; api pin039b9e7c254328051faddb210ad58980b5ceb890).setis a full upsert (-project -name -location -deployment -port -pathdefault/metrics-disabled)querytakes repeatable-seriesand-timerange 1h|6h|12h|1d|7d|30d(default1h)alert create/updategrow-kind deployment|custom,-source,-series;-metricalso acceptsvalue|rate'>='/'<='so shells do not treat them as redirectionsTesting
No PR CI in this repo — verified locally:
go test ./... && go vet ./... && go buildgreen;deploys metricsource -handdeploys alert create -hmention kind/source.